Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip with reason dynamic table tests with reference to PR. #1080

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Skip with reason dynamic table tests with reference to PR. #1080

merged 1 commit into from
Jun 11, 2024

Conversation

VersusFacit
Copy link
Contributor

Problem

If you look at the logs for 1.6.latest they have broken for weeks. This is related to the change in Snowflake on dynamic table metadata. We have a fix for this but it was determined only for 1.7 and 1.8, not any other versions.

Solution

I am adding skips to turn that off make the signal meaningful again.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Jun 11, 2024
@VersusFacit VersusFacit self-assigned this Jun 11, 2024
@cla-bot cla-bot bot added the cla:yes label Jun 11, 2024
@VersusFacit VersusFacit merged commit fe83393 into 1.6.latest Jun 11, 2024
39 checks passed
@VersusFacit VersusFacit deleted the skip_dynamic_table_tests branch June 11, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VersusFacit @colin-rogers-dbt